Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Separating cudnn common utils from fused_attn #1314

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

phu0ngng
Copy link
Collaborator

@phu0ngng phu0ngng commented Nov 5, 2024

Description

In this PR, the common cudnn helpers are moved out of fused attention so that they can be used in other kernels, i.e. the coming normalization.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@phu0ngng
Copy link
Collaborator Author

phu0ngng commented Nov 6, 2024

/te-ci pytorch

Copy link
Collaborator

@cyanguwa cyanguwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Phuong Nguyen <[email protected]>
@phu0ngng
Copy link
Collaborator Author

phu0ngng commented Nov 8, 2024

/te-ci pytorch

@phu0ngng phu0ngng removed the request for review from timmoon10 November 8, 2024 16:39
@phu0ngng phu0ngng merged commit 2643ba1 into NVIDIA:main Nov 8, 2024
14 of 15 checks passed
@phu0ngng phu0ngng deleted the cudnn_utils branch November 8, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants